chore: improve build responsiveness #2992
Conversation
| } | ||
| } | ||
|
|
||
| const process = processes.find(p => p.cmd.includes("postcss") && p.cmd.endsWith(`-w --packageName=${packageName}`)); |
There was a problem hiding this comment.
better make this p.cmd.includes which has the same effect but is less error prone in case someone adds more parameters to the postcss command
There was a problem hiding this comment.
I put endsWithbecause @ui5/webcomponents will also match @ui5/webcomponents-fiori.
| if (process) { | ||
| await fkill(process.pid); | ||
|
|
||
| exec(`npx nps build.styles.components`, (err, stdout, stderr) => { |
There was a problem hiding this comment.
isn't the watch below sufficient because a new start will see the newly added files?
There was a problem hiding this comment.
It turns out no, that's why probably we have first build.styles.components and only then watch.styles.components. The -w flag does not execute the initial action.
| console.log(stdout); | ||
| }); | ||
|
|
||
| exec(`npx nps watch.styles.components`, (err, stdout, stderr) => { |
There was a problem hiding this comment.
not sure if starting npx from yarn won't have additional problems. could we reuse the nps api with require?
There was a problem hiding this comment.
I didn't find any. That was my initial intention too. I could only find nps-utils.
| @@ -62,12 +64,14 @@ const getScripts = (options) => { | |||
| es5: 'rollup --config config/rollup.config.js -w --environment ES5_BUILD,DEV,DEPLOY_PUBLIC_PATH:/resources/' | |||
| }, | |||
| styles: { | |||
| default: 'concurrently "nps watch.styles.themes" "nps watch.styles.components"', | |||
| default: 'concurrently "nps watch.styles.themes" "nps watch.styles.components" "nps watch.styles.monitor"', | |||
There was a problem hiding this comment.
watch and monitor are the same thing, something like restart-on-add is more descriptive
There was a problem hiding this comment.
There are a couple of general problems:
- I still can't have it work on windows: the
ps-listmodule ships a binary that simulates ps on windows, but it does not provide the full command, only the name of the executable "something.exe" without any parameters. Runningpson the git bash is the same. - Sometimes the
ps-listfails with a promise rejection on Mac, therefore the retry. The retry works, but once I had an error trying to kill the current postcss process.
This change fixes 2 bugs of the
yarn startcommand:.cssfiles are not usable unlessyarn startis killed and re-run. The reason is a knownpostcssbug in--watchmode: newly created files are not detected, only existing files are re-compiled (--watch mode doesn't pick up new files postcss/postcss-cli#161).messagebundle.propertiesare not automatically available ini18n-defaults.jsand if you try to use them - the bundle breaks. This is due to the fact that there is no watch mode fori18n.Changes:
chokidarfor watching thethemes/directory and for each newly added file runpostcssto build this file only, and then run againpostcss -wto start watching it.watchtask fori18ntoo: it only needs to watch themessagebundle.propertiesfile and regenerate the defaults file (not the.jsons).After the change it's possible to create a new component with all needed files and resources without restarting
yarn start.