Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-flexible-column-layout): migrate to TypeScript #6335

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Jan 23, 2023

Migrated FlexibleColumnLayout component to TypeScript.

packages/fiori/src/FlexibleColumnLayout.ts Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Show resolved Hide resolved
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approve since there is open review comments

@hinzzx hinzzx mentioned this pull request Jan 24, 2023
29 tasks
@ilhan007
Copy link
Member

ilhan007 commented Jan 30, 2023

You may keep "0px" for the built-in layout configuration, but you need to ensure backward compatibility.
There are number of wrong states, caused by the change from 0 to "0px" (read the inline comments for more details).
In general, the code should work the same way with "0px" and 0. I suggest creating a method that checks against both the values and returns true if one of the conditions is true -returns v ==="0px" || v === 0. This will make the code working as before and letting us use only strings for the column layout.

@hinzzx hinzzx requested a review from ilhan007 February 3, 2023 10:20
@hinzzx hinzzx merged commit c21255b into main Feb 6, 2023
@hinzzx hinzzx deleted the fcl-to-ts-1 branch February 6, 2023 10:46
kskondov pushed a commit that referenced this pull request Feb 10, 2023
* Component <ui5-flexible-column-layout> migrated to TypeScript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants