Fix: Open editor with default value #1406
Merged
+18
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1405, reverting the bugs introduced in 8328d65 (the editor opens without defaults, and Inquirer renders text on top of in-terminal editors such as
vi
).Changes Made
The editor now opens only after
this.currentText
has been set, and the initial render does not occur ifwaitUserInput
is false.Testing
The previous tests for the editor prompt do not make use of the
default
property set in the editor fixture. The message written to the temporary file and its expected contents are turned into test parametersmessage
andexpectedAnswer
, respectively. Two additional test cases are added in which the test editorwriteBin
is called without the final argument (message = ''
), which should leave the contents of the file untouched.