Plot refactoring #207
Open
Plot refactoring #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: added option to plot test distribution's mean. styl: homogenized plot_poisson_consistency_test and plot_consistency_test
…d can be instatiated using keywords. These kw can be passed from plotting functions, replacing the old plot_args dictionary. Example: plot_spatial_dataset(data, figsize=(10,2), title='hola'). feat: Prepared plot_consistency_test as candidate to generalize plot_poisson_consistency_test. Should we leave poisson as a legacy function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR
Started refactoring work on plotting functions. The idea, is that now plot wrapper functions can receive keywords, which will be then passed to matplotlib specific funcs. A class PlotArgs is created, contained the default options (categorized by usage), whose attributes would be updated on instantiation if a kw is passed.
If we do not want to break previous code, we could create a wrapper if the old plot_args is passed (now as optional), that returns a PlotArgs class.
PR Type
Checklist: