New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAH-1360: Upgrade Partners to React 18 #584
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
aa095e4
fix: app works, working through tests
chadbrokaw 425304f
More tests
chadbrokaw bbda8ef
Atom tests
chadbrokaw 088093d
next wave of tests
chadbrokaw d428da0
more tests
chadbrokaw dd960e8
more tests
chadbrokaw 1c4f376
more tests
chadbrokaw fb3f5aa
more tests
chadbrokaw 5d4a4dd
add mini-css-extract
chadbrokaw bf0fe59
Fix rspec tests
chadbrokaw 0a4fb16
Add more time to failing test
chadbrokaw d7f4559
fix dep
chadbrokaw ccc5893
fix dep
chadbrokaw b5b7653
fix webpack
chadbrokaw bbec448
postcss-preset-env
chadbrokaw a2c7b8d
clean up testing
chadbrokaw 05a0a3d
Fix test snapshot
chadbrokaw 2ba582a
cleanup
chadbrokaw 3c643cd
JL PR Feedback
chadbrokaw b3c9ca2
e2e issues
chadbrokaw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,15 @@ | ||
{ | ||
"javascript.validate.enable": true, | ||
"jest.disabledWorkspaceFolders": [ | ||
"spec/javascript/e2e" | ||
], | ||
"editor.codeActionsOnSave": { | ||
// For ESLint | ||
"source.fixAll.eslint": true, | ||
}, | ||
"eslint.format.enable": true, | ||
"eslint.lintTask.enable": true, | ||
"eslint.packageManager": "yarn", | ||
"jest.runAllTestsFirst": false, | ||
"jest.rootPath": "./", | ||
"autoimport.sourceRoot": "./app/javascript", | ||
"autoimport.semicolon": false, | ||
"autoimport.absolute": true, | ||
} | ||
"javascript.validate.enable": true, | ||
"jest.disabledWorkspaceFolders": ["spec/javascript/e2e"], | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll.eslint": true | ||
}, | ||
"eslint.format.enable": true, | ||
"eslint.lintTask.enable": true, | ||
"eslint.packageManager": "yarn", | ||
"jest.runAllTestsFirst": false, | ||
"jest.rootPath": "./", | ||
"autoimport.sourceRoot": "./app/javascript", | ||
"autoimport.semicolon": false, | ||
"autoimport.absolute": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
# rails: bin/rails server -p 3000 | ||
webpack: bin/webpack-dev-server --hot | ||
webpack: bin/shakapacker-dev-server --hot |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: are these comments even necessary? We have git to record this information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they seem like clutter to me... I'm good to remove them