-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Audio module types #2927
Conversation
f4a468d
to
42f01c4
Compare
https://github.com/SFML/SFML/actions/runs/8573099270/job/23497199870#step:19:141 For some reason after adding new |
42f01c4
to
ff6311c
Compare
360d780
to
5bb143e
Compare
Pull Request Test Coverage Report for Build 9116395159Details
💛 - Coveralls |
29e5a25
to
86c3efd
Compare
0db24e6
to
3c3f4d3
Compare
I'm marking this as ready for review because these tests catch a bug in the current implementation of #2749 and detect some minor behavior changes. I think it's worth merging these tests first so that the Miniaudio PR can benefit from some better automated testing. |
483c4b3
to
1b78632
Compare
452db9d
to
bd3e1bf
Compare
bd3e1bf
to
f604aaf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2927 +/- ##
==========================================
+ Coverage 43.65% 45.01% +1.36%
==========================================
Files 253 253
Lines 20940 20947 +7
Branches 5139 5160 +21
==========================================
+ Hits 9142 9430 +288
+ Misses 10785 10469 -316
- Partials 1013 1048 +35 see 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
With the changes from #2966 I was able to enable the audio tests on Windows as well! This PR is ready to merge once the BuildBot is updated to set |
84e9db1
to
963f14c
Compare
Description
This will remain a draft PR until #2749 is merged as to avoid introducing more merge conflicts into that PR.I first wrote these tests a long time ago but just realized that we can use the trick as we do for the tests that require a display. Only the macOS jobs include an audio device so that's the only OS on which we can run these tests. Not great but better than nothing. These tests should still pass on everyone's own development machine since we all use computers with sound cards.
Coverage of these Audio module types is not perfect but we can improve that later once this first tranche of tests is merged.