Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM build causes previously passing Jest tests to fail #113

Open
1 task
Byron-Wall opened this issue Oct 24, 2019 · 2 comments
Open
1 task

ESM build causes previously passing Jest tests to fail #113

Byron-Wall opened this issue Oct 24, 2019 · 2 comments

Comments

@Byron-Wall
Copy link

Thanks for opening an issue!

Please select the type of issue you're reporting. For questions.

  • [x ] Bug
  • [x ] Feature Request
  • Question

Problem Report

Please describe the problem here.
Previously passing jest tests fail with the output:

Details:

node_modules/react-resizable/node_modules/react-draggable/build/Draggable.js:56
            prevPropsPosition: { ...position
                                 ^^^

    SyntaxError: Unexpected token ...

System Info

Node Version: 6.14.4
Browser: JSDOM
OS: X

Reproduction

Run a jest test on a component that imports react-resizable

#######FIX############
the fix is:
add react-resizable to the projects' jest config's transformIgnorePatterns, like so:

    "transformIgnorePatterns": [
      "<rootDir>/node_modules/(?!react-resizable)"
    ],
@Byron-Wall
Copy link
Author

I'd guess the feature request is really a docs PR, which I can do later if needed

@eric-burel
Copy link

eric-burel commented Dec 12, 2019

It does not seem to break only Jest but also breaks one of my older Electron app
Am I expected to update something in my app for this to work? Maybe the Babel version?

Edit: finally got it by locking react-resizable to 1.8 explictely, when using react-grid-layout. Some older app won't be happy with the Babel 7 update, so they need to use this version before they update Babel themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants