Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework build process & add "module" to package.json. #441

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Oct 25, 2019

This is a refactor of our build to now include three targets:

  • "main": ES5-compatible CJS build, suitable for most use cases with maximum compatibility
  • "web": Minified UMD bundle exporting to window.ReactDraggable with the same ES compatibility as the "main" build
  • "module": ES6-compatible build using import/export.

This should fix issues like react-grid-layout/react-resizable#113 while allowing modern bundlers to consume esm modules in the future.

This allows us to export a cjs build that is more ES5-like
to avoid issues with JSDOM, PhantomJS, etc.
This ensures we're testing both build types
Finishes refactor. Dev, test, lint, and build all working.
@STRML STRML merged commit e055f96 into master Oct 25, 2019
@STRML STRML deleted the fix/module-build branch October 25, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant