fix(packages/sui-ssr): fix ssr lock file update for npm 7 #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoralp
requested review from
jcger,
kikoruiz,
midudev and
sui-bot
as code owners
rmoralp
commented
May 26, 2021
| '--progress false', | ||
| '--no-bin-links', | ||
| '--ignore-scripts' | ||
| ] |
There was a problem hiding this comment.
ℹ️ Improve readability and will avoid extra spaces when joining the array.
andresin87
approved these changes
May 26, 2021
javiauso
approved these changes
May 26, 2021
tomasmax
approved these changes
May 26, 2021
kikoruiz
approved these changes
May 26, 2021
jcger
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have experienced some troubleshooting with
--package-lock-onlyoption in npm 7.As we can see in npm CLI issue: npm/cli#2747 "the right behaviour is what npm 6 eventually did - package-lock-only implies package-lock. This was an unintentional breaking change in v7."
For that reason, this PR requires a clean install (deleting lock file and adding node_modules) in order to generate a correctly new lock file and use it for the release.