tests/test_repository.py: Move from dnf repoclosure to zypper + installcheck #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vogtinator
force-pushed
the
installcheck
branch
from
1334ef6
to
59b9579
Compare
dirkmueller
reviewed
Mar 25, 2024
dirkmueller
reviewed
Mar 25, 2024
dirkmueller
reviewed
Mar 25, 2024
Vogtinator
force-pushed
the
installcheck
branch
from
59b9579
to
e26f4af
Compare
dirkmueller
reviewed
Mar 26, 2024
There was a problem hiding this comment.
code wise this change is fine by me. I am not 100% certain that repocheck had no other additional usecases over installcheck though.
from the chat we had yesterday I however understood that we add installcheck into the bci repo publishing pipeline not remove it from bci-tests? what am I missing?
Correct. I had a look but there were two issues:
Changing the code here instead avoided both |
Vogtinator
force-pushed
the
installcheck
branch
from
e26f4af
to
ea11324
Compare
dcermak
reviewed
Apr 3, 2024
dcermak
reviewed
Apr 3, 2024
Vogtinator
force-pushed
the
installcheck
branch
from
5a00dad
to
f7cea0c
Compare
…llcheck Avoids workarounds and dependency on a fedora container.
dcermak
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids workarounds and dependence on a fedora container.