[pull] main from microsoft:main #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* [react-native] Fix Hermes version mismatch * Address PR comments * Update packages/react-native/sdks/hermes-engine/hermes-utils.rb Co-authored-by: Saad Najmi <sanajmi@microsoft.com> --------- Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
* Remove stale pbxproj entries * Fix macos version typos in ruby scripts
* Update to Xcode 15.2 * Update .ado/variables/vars.yml Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> --------- Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
* Remove TARGET_OS_UIKITFORMAC macros (facebook#42278) Summary: There seems to be a lot of `TARGET_OS_UIKITFORMAC` macro in React Native that don't need to be there. Let's remove them. First off, what is `TARGET_OS_UIKITFORMAC` targeting? You might think it's [Mac Catalyst](https://developer.apple.com/mac-catalyst/), if you look at the [commit](facebook@3724810) introducing the ifdefs. However.. that doesn't seem right because `TARGET_OS_MACCATALYST` exists, and is used elsewhere in the codebase. In fact, if you look at this handy comment inside `TargetConditionals.h` (the file that defines all these conditionals), `TARGET_OS_UIKITFORMAC` is not even on there! ``` /* * TARGET_OS_* * * These conditionals specify in which Operating System the generated code will * run. Indention is used to show which conditionals are evolutionary subclasses. * * The MAC/WIN32/UNIX conditionals are mutually exclusive. * The IOS/TV/WATCH/VISION conditionals are mutually exclusive. * * TARGET_OS_WIN32 - Generated code will run on WIN32 API * TARGET_OS_WINDOWS - Generated code will run on Windows * TARGET_OS_UNIX - Generated code will run on some Unix (not macOS) * TARGET_OS_LINUX - Generated code will run on Linux * TARGET_OS_MAC - Generated code will run on a variant of macOS * TARGET_OS_OSX - Generated code will run on macOS * TARGET_OS_IPHONE - Generated code will run on a variant of iOS (firmware, devices, simulator) * TARGET_OS_IOS - Generated code will run on iOS * TARGET_OS_MACCATALYST - Generated code will run on macOS * TARGET_OS_TV - Generated code will run on tvOS * TARGET_OS_WATCH - Generated code will run on watchOS * TARGET_OS_VISION - Generated code will run on visionOS * TARGET_OS_BRIDGE - Generated code will run on bridge devices * TARGET_OS_SIMULATOR - Generated code will run on an iOS, tvOS, watchOS, or visionOS simulator * TARGET_OS_DRIVERKIT - Generated code will run on macOS, iOS, tvOS, watchOS, or visionOS * * TARGET_OS_EMBEDDED - DEPRECATED: Use TARGET_OS_IPHONE and/or TARGET_OS_SIMULATOR instead * TARGET_IPHONE_SIMULATOR - DEPRECATED: Same as TARGET_OS_SIMULATOR * TARGET_OS_NANO - DEPRECATED: Same as TARGET_OS_WATCH * * +--------------------------------------------------------------------------------------+ * | TARGET_OS_MAC | * | +-----+ +------------------------------------------------------------+ +-----------+ | * | | | | TARGET_OS_IPHONE | | | | * | | | | +-----------------+ +----+ +-------+ +--------+ +--------+ | | | | * | | | | | IOS | | | | | | | | | | | | | * | | OSX | | | +-------------+ | | TV | | WATCH | | BRIDGE | | VISION | | | DRIVERKIT | | * | | | | | | MACCATALYST | | | | | | | | | | | | | | * | | | | | +-------------+ | | | | | | | | | | | | | * | | | | +-----------------+ +----+ +-------+ +--------+ +--------+ | | | | * | +-----+ +------------------------------------------------------------+ +-----------+ | * +--------------------------------------------------------------------------------------+ */ ``` Going even deeper into `TargetConditionals.h`, you will see `TARGET_OS_UIKITFORMAC` defined... and it's always 1 when `TARGET_OS_MACCATALYST` is 1, making it feel even more redundant. My current conclusion is it's either another variant of Mac Catalyst (the one where they just run unmodified UIKit maybe..), or it's an older macro back from when Catalyst was still experimental. Either way, it's pretty obvious nobody is running or testing this codepath, and it adds bloat, especially to React Native macOS where we have extra ifdef blocks for macOS support (and eventually visionOS support). Let's remove it. Another change I made while we're here: I've seen this lingering TODO to replace setTargetRect:InView: / setMenuVisible:animated: (deprecated as of iOS 13, below our minimum OS requirement) with showMenuFromView (deprecated as of iOS 16, in line with the availability check). Let's just.... do that? [IOS] [REMOVED] - Remove TARGET_OS_UIKITFORMAC macros Pull Request resolved: facebook#42278 Test Plan: RNTester with Mac Catalyst still compiles:  Reviewed By: cipolleschi Differential Revision: D52780690 Pulled By: sammy-SC fbshipit-source-id: df6a333e8e15f79de0ce6f538ebd73b92698dcb6 * Remove an early return to suppress a deprecated API warning for `UIMenuController` (facebook#42277) Summary: `UIMenuController` is deprecated as of iOS 16. facebook@e08a197 migrated a usage into an `available` check. However, it does not properly fall back to the deprecated API in the "else" block of the availability check, instead it uses an early return. It seems this means Xcode still sees the API as used, and spits out a deprecated warning. Let's just refactor the code so we don't have that anymore. [IOS] [FIXED] - Remove an early return to suppress a deprecated API warning for `UIMenuController` Pull Request resolved: facebook#42277 Test Plan: CI should pass. Reviewed By: cipolleschi Differential Revision: D52785488 Pulled By: sammy-SC fbshipit-source-id: 0b47e8aa8d7c94728e3d68332fbb8f97f8ded34e * Native changes for visionOS
…into maintva11y
#### Please select one of the following - [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍 - [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍 - [x] I am making a fix / change for the macOS implementation of react-native - [ ] I am making a change required for Microsoft usage of react-native ## Summary: main version of PR #1992 ## Test Plan: Verified it works as expected in main. See other PR for details
Co-authored-by: Tomasz Sapeta <tsapeta@users.noreply.github.com>
* chore(cli): deprecate `--configuration` * fix: apply reviewer's comments
* iOS: Introduce `vision` interfaceIdiom (facebook#42243) Summary: This PR introduces the `vision` interfaceIdiom to check if the app runs on visionOS. An update to the documentation should follow this change. [IOS] [ADDED] - Introduce `vision` interfaceIdiom Pull Request resolved: facebook#42243 Test Plan: This change has been used in `react-native-visionos` and the interfaceIdiom changes **only** when running in the non-compatibility mode. But it's still useful to have this upstream if at some point React native would compile to visionOS natively Reviewed By: cortinico Differential Revision: D52730028 Pulled By: cipolleschi fbshipit-source-id: 711c5c2c6c7fe05b3ff8da7383b5e63e9e04acfa * fix: isVision return false for Platform.android.js (facebook#42381) Summary: This PR is a follow up for facebook#42243 it looks like we need to return `false` for the Platform.android.js to make flow happy. This is the error we were getting in `react-native-visionos` CI/CD:  [INTERNAL] [FIXED] - Add `isVision` interface idiom for Platform.android.js Pull Request resolved: facebook#42381 Test Plan: CI Green Reviewed By: cortinico Differential Revision: D52905993 Pulled By: NickGerleman fbshipit-source-id: 125d33b63e9114cb6276b554e426f32e0c406ea8 * Implement isVision for macOS --------- Co-authored-by: Oskar Kwaśniewski <oskarkwasniewski@icloud.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
## Summary: Our pull request template has a section for a changelog, which is currently unused because we don't (and can't) use the same tool for changelog generation as upstream. Instead, we use the Github built in changelog generator, which mostly takes PR titles. Let's just remove that section from our template. ## Test Plan: Not really applicable.
## Summary: main targeted PR of #2100 Prior to 0.73, the new `role` prop was remapped to `accessibilityRole` on the JS-side. Starting with facebook#37304, the work needs to be completed on the native side. Since the new prop is ARIA inspired, the mappings are taking from the [ARIA Core AAM](https://www.w3.org/TR/core-aam-1.2/#mapping_role_table) which disagrees with some of the mappings used in the old `accessibilityRole` prop. Users of the old prop are unaffected, but the new prop will take the mappings from the spec. ## Test Plan: Tested a variety of permutations of accessibilityRole and role to confirm the behavior looks correct in Accessibility Inspector
* Ensure ghost text doesn't appear when performing undos * Clarify purpose of strict mode in `removingGhostTextFromString:strict:` * Add clarifying comments about `removingGhostTextFromString:strict:` nil checks --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.0 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.0...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The four fields below are mandatory. --> <!-- This fork of react-native provides React Native for macOS for the community. It also contains some changes that are required for usage internal to Microsoft. We are working on reducing the diff between Facebook's public version of react-native and our microsoft/react-native-macos fork. Long term, we want this fork to only contain macOS concerns and have the other iOS and Android concerns contributed upstream. If you are making a new change then one of the following should be done: - Consider if it is possible to achieve the desired behavior without making a change to microsoft/react-native-macos. Often a change can be made in a layer above in facebook/react-native instead. - Create a corresponding PR against [facebook/react-native](https://github.com/facebook/react-native) **Note:** Ideally you would wait for Facebook feedback before submitting to Microsoft, since we want to ensure that this fork doesn't deviate from upstream. --> ## Summary: <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fix for issue #2111 (NSTabView doesn't send mouseUp event because it doesn't inherit from NSControl). NSTabView inherits from NSView, not NSControl, so its click events aren't recorded in the _nativeTouches cache leading to mouseUp and mouseDown not firing consistently when clicking on the tab buttons. ## Test Plan: <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. --> Code for custom TabView component provided in the linked issue.
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.5...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* Replace `--frozen-lockfile` with --immutable * Remove `apple-install-dependencies * Update apple-xcode-select * Use macos-13-arm64 * Build Debug only * Use custom Xcodebuild template * Separate build & test * Use Codeql v2 * Update template syntax * try major refactor * rename apple-job-publish * try big 2 * Fix Hermes * Comment out test temporarily * Fix visionOS + New Arch + JSC * Move iOS down, visionOS -> xrOS * Comment out failing jobs * Update build-test-rntester.yml * Move scripts to scripts folder * Update RNTA script for RNM use * Update VM image per notice * Update gitignore * Don't test on visionOS * fix use out-of-scope memory warning (facebook#41441) Summary: Pull Request resolved: facebook#41441 changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760 fbshipit-source-id: 5fc7ab22220e3d80729243e715e22e85e3ba7afa * Retry xcode tests on failure --------- Co-authored-by: Samuel Susla <samuelsusla@meta.com>
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.2.8 - 2024-05-16</h2> <h3>Fixes</h3> <ul> <li>Suppressed a warning</li> </ul> <h2>REXML 3.2.7 - 2024-05-16</h2> <h3>Improvements</h3> <ul> <li> <p>Improve parse performance by using <code>StringScanner</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/106">GH-106</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/107">GH-107</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/108">GH-108</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/109">GH-109</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/112">GH-112</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/113">GH-113</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/114">GH-114</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/115">GH-115</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/116">GH-116</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/117">GH-117</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/118">GH-118</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/119">GH-119</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/121">GH-121</a></p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Improved parse performance when an attribute has many <code><</code>s.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/124">GH-124</a></li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>XPath: Fixed a bug of <code>normalize_space(array)</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/111">GH-111</a></p> </li> <li> <p>Patch by flatisland.</p> </li> </ul> </li> <li> <p>XPath: Fixed a bug that wrong position is used with nested path.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/122">GH-122</a></p> </li> <li> <p>Reported by jcavalieri.</p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Fixed a bug that an exception message can't be generated for invalid encoding XML.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.2.8 - 2024-05-16 {#version-3-2-8}</h2> <h3>Fixes</h3> <ul> <li>Suppressed a warning</li> </ul> <h2>3.2.7 - 2024-05-16 {#version-3-2-7}</h2> <h3>Improvements</h3> <ul> <li> <p>Improve parse performance by using <code>StringScanner</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/106">GH-106</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/107">GH-107</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/108">GH-108</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/109">GH-109</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/112">GH-112</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/113">GH-113</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/114">GH-114</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/115">GH-115</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/116">GH-116</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/117">GH-117</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/118">GH-118</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/119">GH-119</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/121">GH-121</a></p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Improved parse performance when an attribute has many <code><</code>s.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/124">GH-124</a></li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>XPath: Fixed a bug of <code>normalize_space(array)</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/111">GH-111</a></p> </li> <li> <p>Patch by flatisland.</p> </li> </ul> </li> <li> <p>XPath: Fixed a bug that wrong position is used with nested path.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/122">GH-122</a></p> </li> <li> <p>Reported by jcavalieri.</p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Fixed a bug that an exception message can't be generated for</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/1cf37bab79d61d6183bbda8bf525ed587012b718"><code>1cf37ba</code></a> Add 3.2.8 entry</li> <li><a href="https://github.com/ruby/rexml/commit/b67081caa807fad48d31983137b7ed8711e7f0df"><code>b67081c</code></a> Remove an unused variable (<a href="https://redirect.github.com/ruby/rexml/issues/128">#128</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/94e180e939baff8f7e328a287bb96ebbd99db6eb"><code>94e180e</code></a> Suppress a warning</li> <li><a href="https://github.com/ruby/rexml/commit/d574ba5fe1c40adbafbf16e47533f4eb32b43e60"><code>d574ba5</code></a> ci: install only gems required for running tests (<a href="https://redirect.github.com/ruby/rexml/issues/129">#129</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/4670f8fc187c89d0504d027ea997959287143453"><code>4670f8f</code></a> Add missing Thanks section</li> <li><a href="https://github.com/ruby/rexml/commit/9ba35f9f032c07c39b8c86536ac13a9cb313bef2"><code>9ba35f9</code></a> Bump version</li> <li><a href="https://github.com/ruby/rexml/commit/085def07425561862d8329001168d8bc9c75ae8f"><code>085def0</code></a> Add 3.2.7 entry</li> <li><a href="https://github.com/ruby/rexml/commit/4325835f92f3f142ebd91a3fdba4e1f1ab7f1cfb"><code>4325835</code></a> Read quoted attributes in chunks (<a href="https://redirect.github.com/ruby/rexml/issues/126">#126</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/e77365e2d1c9cdb822c7e09b05fc5a4903d92c23"><code>e77365e</code></a> Exclude older than 2.6 on macos-14</li> <li><a href="https://github.com/ruby/rexml/commit/bf2c8edb5facb206c25a62952aa37218793283e6"><code>bf2c8ed</code></a> Move development dependencies to Gemfile (<a href="https://redirect.github.com/ruby/rexml/issues/124">#124</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.2.5...v3.2.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/react-native-macos/network/alerts). </details>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/node-ip/commit/1ecbf2fd8c0cc85e44c3b587d2de641f50dc0217"><code>1ecbf2f</code></a> 1.1.9</li> <li><a href="https://github.com/indutny/node-ip/commit/6a3ada9b471b09d5f0f5be264911ab564bf67894"><code>6a3ada9</code></a> lib: fixed CVE-2023-42282 and added unit test</li> <li>See full diff in <a href="https://github.com/indutny/node-ip/compare/v1.1.8...v1.1.9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/react-native-macos/network/alerts). </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
Summary: This PR resolves issues with retrieving appearance in multi-window apps by calling `RCTKeyWindow()` instead of retrieving the AppDelegate window property. It also does small optimization in the RCTAlertController. [IOS] [FIXED] - Fix retrieving current appearance in multi-window apps Pull Request resolved: facebook#42231 Test Plan: CI Green, it should work the same as before Reviewed By: NickGerleman Differential Revision: D52802756 Pulled By: cipolleschi fbshipit-source-id: 60b5f7045f41be19caae5102f0dc321d4ecdcd2f
…2125) ## Summary: Cherry pick facebook@d00d35e to fix a bug we're seeing internally ## Test Plan: CI should pass
…ebook#39835) Summary: …king root view frame changes Looking through where this was introduced (facebook#37649), it seems the notification went from tracking root view size changes to window size changes. However, it was not renamed. I was using it for root view changes in RN-macOS, which.. I guess I'll refactor. Meanwhile, let's update the name? ## Changelog: [IOS] [CHANGED] - Rename `RCTRootViewFrameDidChangeNotification` as it's not tracking root view frame changes Pull Request resolved: facebook#39835 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D50173742 Pulled By: javache fbshipit-source-id: 4651696174c439800984a5e6cf642200bb9c4f3c
…#42396) Summary: Pull Request resolved: facebook#42396 Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604 fbshipit-source-id: 1727bcdef5393b1bd5a272e2143bc65456c2a389
…o module (facebook#43737) Summary: Previous fix brings in facebook#42396. Seems it's a mistake to re-add observer? So let's remove it and also not `invalidate` method not be called twice. [IOS] [FIXED] - Remove invalidate observer instead of re-adding observer in DeviceInfo module Pull Request resolved: facebook#43737 Test Plan: Fix for facebook#42120 also works. Reviewed By: javache Differential Revision: D55692219 Pulled By: cipolleschi fbshipit-source-id: dba1ddc39a9f2611fc2b84fadf8c23827891379a
## Summary: Pick up facebook@d46d80d and facebook@44159e3 from upstream to fix a potential hang we're seeing internally ## Test Plan: CI should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )