Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-12582733: Adding env-var endpoint for Manager's smoke tests #1178

Draft
wants to merge 3 commits into
base: v2-archive-20230512
Choose a base branch
from

Conversation

josebarrios-sfdc
Copy link
Contributor

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@salesforce-cla
Copy link

salesforce-cla bot commented May 8, 2023

Thanks for the contribution! It looks like @josebarrios-sfdc is an internal user so signing the CLA is not required. However, we need to confirm this.

'deploy_id',
'deploy_target',
'external_domain_name',
'mobify_property_id',
'node_env',
'tz'
'tz',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fails the lint check in CI, fixable with npm run lint:fix after running npm ci from pwa-kit root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants