[FEATURE] Add stylesheet loader to PWA-Kit SDK #1650
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the result of multiple requests to add CSS file loader support to the PWA-Kit platform. The issue in question specifically was when a developer was following Chakra documentation on how to use custom font, but was not able to successfully follow the steps as our code sdks don't support css loading.
Being that the
template-retail-react-app
is the biggest and most used template we provide, I think it's reasonable to consider it a bug that our template, which uses chakra, can't add custom fonts (via css) as prescribed.In this PR we add css loaders to the SDKs and update the rendering-pipeline to ensure things still work for server-side rendering.
Known Issues
publicPath
setting.. (Definitely not correct for production builds)TODO:
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization