Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-14902130 - Allow ProductId and CategoryId to be passed directly their respective pages #1738

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bendvc
Copy link
Collaborator

@bendvc bendvc commented Apr 8, 2024

Description

This simple PR makes small change to the and pages to allow you to pass in the ProductId and CategoryId respectively. We are adding this ability in preparation for work adding the Shopper SEO API to the template.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Changes

  • Add 'productId' prop to the ProductDetail page component
    • Add 'categoryId' prop to the ProductList page component

How to Test-Drive This PR

  • (step1)

TODO

  • Revert changes to routes.jsx
  • Update tests.

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant