Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): inject rxjs path into any-observable #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aleclarson
Copy link

When installing listr with pnpm, an issue occurs where any-observable cannot find any Observable implementation. Since listr already depends on rxjs, we can just inject it before importing any-observable.

Related: pnpm/pnpm#1496

@aleclarson
Copy link
Author

Might need a try..catch in here. 🤔

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #127 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   96.31%   96.33%   +0.01%     
==========================================
  Files           7        7              
  Lines         190      191       +1     
==========================================
+ Hits          183      184       +1     
  Misses          7        7
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe40ce5...3e5049e. Read the comment docs.

@IanVS
Copy link

IanVS commented Jan 22, 2020

This seems to also break the usage of lint-staged when using yarn v2. Is there any chance that you can put some eyes on this, @SamVerschueren?

@BeeeQueue
Copy link

Also seeing this issue with yarn v2. @SamVerschueren

@BeeeQueue
Copy link

@SamVerschueren Please take a look at this PR. 😢

@MarcoScabbiolo MarcoScabbiolo mentioned this pull request Apr 16, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants