Update test discovery for pytest 6 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'args' keyword for the pytest.Function.from_parent constructor was removed with pytest 6. It was unused in pytest [1] and was always an empty tuple in the sasmodels code. [1] pytest-dev/pytest#7226
Allowing CI to run on all branches means that CI runs *before* the PR is made rather than afterwards.
|
sasmodels ready for testing on OSX |
1 similar comment
|
sasmodels ready for testing on OSX |
wpotrzebowski
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'args' keyword for the pytest.Function.from_parent constructor was removed with pytest 6.0.0rc1. It was unused in pytest and in the sasmodels code
argswas always an empty tuple.This PR removes the use of
argswhich permits pytest versions from (at least) 3.10.1 to 6.0.2 to work (tested with Debian stable and unstable) plus CI on github actions.This PR also removes the unnecessary limitation of only testing the master branch in CI, meaning that developers can actually verify that CI passes before creating PRs not after.
Closes: #424