Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(go.mod): remove deprecated comment #239

Merged
merged 1 commit into from Sep 28, 2023
Merged

docs(go.mod): remove deprecated comment #239

merged 1 commit into from Sep 28, 2023

Conversation

EtienneM
Copy link
Member

The issue mentionned in the comment is now fixed. The etcd dependency is compatible with google.golang.org/grpc versions >= 1.30.

@EtienneM EtienneM self-assigned this Sep 28, 2023
@EtienneM EtienneM marked this pull request as ready for review September 28, 2023 07:40
SCedricThomas
SCedricThomas approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@SCedricThomas SCedricThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@EtienneM EtienneM merged commit ae5d97c into master Sep 28, 2023
2 checks passed
@EtienneM EtienneM deleted the fix/gomod/remove_comment branch September 28, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SCedricThomas SCedricThomas SCedricThomas approved these changes

Assignees

@EtienneM EtienneM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EtienneM @SCedricThomas