[api-extractor] Don't export trimmed namespace members during rollup (m…

…icrosoft#2791)

apps/api-extractor/src/generators/DtsRollupGenerator.ts

@@ -203,6 +203,15 @@ export class DtsRollupGenerator {
             );
           }
 
+          // If the entity's declaration won't be included, then neither should the namespace export it
+          // This fixes the issue encountered here: https://github.com/microsoft/rushstack/issues/2791
+          const symbolMetadata: SymbolMetadata | undefined =
+            collector.tryFetchMetadataForAstEntity(exportedEntity);
+          const maxEffectiveReleaseTag: ReleaseTag = symbolMetadata
+            ? symbolMetadata.maxEffectiveReleaseTag
+            : ReleaseTag.None;
+          if (!this._shouldIncludeReleaseTag(maxEffectiveReleaseTag, dtsKind)) continue;
+
           if (collectorEntity.nameForEmit === exportedName) {
             exportClauses.push(collectorEntity.nameForEmit);
           } else {

build-tests/api-extractor-test-04/etc/api-extractor-test-04.api.md

@@ -61,14 +61,14 @@ export namespace EntangledNamespace {
 export type ExportedAlias = AlphaClass;
 
 // Warning: (ae-internal-missing-underscore) The name "InternalClass" should be prefixed with an underscore because the declaration is marked as @internal
-// 
+//
 // @internal
 export class InternalClass {
     undecoratedMember(): void;
 }
 
 // Warning: (ae-internal-missing-underscore) The name "IPublicClassInternalParameters" should be prefixed with an underscore because the declaration is marked as @internal
-// 
+//
 // @internal
 export interface IPublicClassInternalParameters {
 }
@@ -83,6 +83,24 @@ export interface IPublicComplexInterface {
 
 export { Lib1Interface }
 
+declare namespace NS {
+  export {
+    NS_PUBLIC,
+    NS_BETA,
+    NS_INTERNAL
+  }
+}
+export { NS }
+
+// @beta (undocumented)
+const NS_BETA = "BETA";
+
+// @internal (undocumented)
+const NS_INTERNAL = "INTERNAL";
+
+// @public (undocumented)
+const NS_PUBLIC = "PUBLIC";
+
 // @public
 export class PublicClass {
     // @internal

build-tests/api-extractor-test-04/src/NamespaceWithTrimming.ts

@@ -0,0 +1,8 @@
+/** @public */
+export const NS_PUBLIC = 'PUBLIC';
+
+/** @beta */
+export const NS_BETA = 'BETA';
+
+/** @internal */
+export const NS_INTERNAL = 'INTERNAL';

build-tests/api-extractor-test-04/src/index.ts

@@ -36,3 +36,10 @@ export type ExportedAlias = AlphaClass;
 export { IPublicComplexInterface } from './IPublicComplexInterface';
 
 export { Lib1Interface } from 'api-extractor-lib1-test';
+
+/**
+ * Test that when exporting namespaces, we don't export members that got trimmed.
+ * See this issue: https://github.com/microsoft/rushstack/issues/2791
+ */
+import * as NS from './NamespaceWithTrimming';
+export { NS };