Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for console applications only #2921

Conversation

excitoon
Copy link
Contributor

Follow up for #1606 .
Possibly as an example and possibly as a real solution. This code should be pretty fast because at the moment of execution application is already read and mapped into virtual memory.
But we might want it to be run at install time and pass wait flag as an argument, I don't know.

@r15ch13
Copy link
Member

r15ch13 commented Dec 20, 2018

Neat! 😮😍

@r15ch13 r15ch13 added enhancement review-needed Asks for review of these changes labels Dec 20, 2018
@excitoon
Copy link
Contributor Author

I guess we should not merge it. I've just understood that some people open programs from Win+R. In this case they would have flickering black window of shim if they run GUI application. I guess we should rewrite this to PowerShell, and run while shimming, setting a flag in .shim like gui = 0/1...

@excitoon excitoon changed the title Wait for console applications only Wait for console applications only [WIP] Dec 20, 2018
@rasa
Copy link
Member

rasa commented Dec 21, 2018

Would it help if we provided a “GUI shim” to call GUI exes, by setting /target:winexe in build.ps1, per here?

@excitoon
Copy link
Contributor Author

excitoon commented Dec 21, 2018

Finally, I decided not to skip waiting in GUI mode because some programs may rely on exit time. For example git rebase -i relies on editor (which can be GUI). Flickering of shim of GUI application is gone anyway.

@excitoon excitoon changed the title Wait for console applications only [WIP] Wait for console applications only Dec 21, 2018
@rasa
Copy link
Member

rasa commented Dec 23, 2020

This issue should be fixed in #3998, which was merged into master. To use, type:

scoop config shim kiennq
scoop reset *

or

scoop config shim 71
scoop reset *

Eventually, one of those shims (probably kiennq) will be made the default.

If this issue is still a problem after trying both solutions above, please reopen this issue. Thanks!

@excitoon

This comment was marked as resolved.

@rasa rasa reopened this Jun 27, 2022
@rasa
Copy link
Member

rasa commented Jun 27, 2022

@excitoon My apologies for closing this. I erroneously thought this issue was fixed by the new shims. Thank you for pointing out that I was mistaken, and for developing this solution.

@rasa
Copy link
Member

rasa commented Jun 27, 2022

I resolved the conflicts, but more work needs to be done before this can be merged, so I am going to convert to a draft.

@rasa rasa marked this pull request as draft June 27, 2022 06:47
@excitoon
Copy link
Contributor Author

@rasa what shall I do now? I actually switched back to Linux since these times :)

@rasa
Copy link
Member

rasa commented Jun 28, 2022

@excitoon Since it was my screw up, I will take on this PR, and move it forward, if that's OK with you. Thanks again for your help.

@excitoon
Copy link
Contributor Author

@rasa okay, no problem, I'm actually not good in PowerShell, anyway

@excitoon
Copy link
Contributor Author

@rasa I just thought we can add a shim for running some applications (16-bit MZ) in DosBox. That is the thing Chocolatey definitely miss.

@excitoon
Copy link
Contributor Author

Hi @rasa . Is there any news? I noticed modern shims can't be killed with Ctrl+C, this is quite inconvenient if you run desktop apps from console.

@rashil2000
Copy link
Member

Merged in #5559

@rashil2000 rashil2000 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement review-needed Asks for review of these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants