perf(scoop-update): Check for running process before wasting time on download #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlwatsonjr
force-pushed
the
test-running-process-before-download
branch
from
b6cbf0a
to
685f5d6
Compare
davidlwatsonjr
changed the title
chawyehsu
changed the title
chawyehsu
previously approved these changes
Mar 27, 2024
niheaven
reviewed
Mar 27, 2024
niheaven
previously approved these changes
Mar 27, 2024
niheaven
force-pushed
the
test-running-process-before-download
branch
from
4652a2d
to
f9afe24
Compare
niheaven
approved these changes
Apr 1, 2024
|
I use proxy to update scoop apps. This feather annoys when I update my proxy app for when I quite the app first and I cannot download anything. Previous version downloading first strategy won't waste time on download as it doesn't delete packages. Can it be a config or scroll back? |
|
There is not much difference in the case of updating your app - You have to close the app eventually to get it updated successfully. You may use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply moves the check for an existing running process to BEFORE the download of the new version. This saves time especially on larger application downloads and slower connections.
Description
As stated, I've simply moved the
test_running_processcall to before the download of the application.Motivation and Context
This change was motivated by an instance where I attempted to
scoop update *and some of the applications were still running. To speed this up, it seemed reasonable to skip the update process for running applications. If and until it's possible to reliably update a running application, this seems a reasonable stop-gap to improve update performance of applications that can be updated.This relates tangentially to #1372 as the update process will at least avoid the pointless download time if the application is running.
How Has This Been Tested?
I ran this locally using
scoop update keepasswhile keepass was running. After my change, everything ran as expected and the running process information was shown, bypassing the download step.Checklist:
developbranch.