Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(shim): Update kiennq-shim to v3.1 #5841

Merged
merged 5 commits into from Mar 22, 2024
Merged

perf(shim): Update kiennq-shim to v3.1 #5841

merged 5 commits into from Mar 22, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Mar 22, 2024

Description

Download from https://github.com/kiennq/scoop-better-shimexe/releases/latest

Motivation and Context

How Has This Been Tested?

VirusTotal:

https://www.virustotal.com/gui/file/554aac610eae2cd61cae3dea0c66fd8283e95eb9c4af5dd9e591197c6a28e119?nocache=1

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiennq Don't know if you have any plan of making a new release of the shim but we are going update the vendored one. Currently v3.0 is the planned but it was released in 2022. Are there any critical commits that need to be considered since then?

I'm blocking this PR to wait for response. Let's wait for 48 hrs at most.

@kiennq
Copy link
Contributor

kiennq commented Mar 22, 2024

Currently v3.0 is the planned but it was released in 2022. Are there any critical commits that need to be considered since then?

There's a commit that prevents the shim from requiring elevated launch unexpectedly when the shim name contains update, install string.
kiennq/scoop-better-shimexe@e0fb559

I've released a new version.

@niheaven niheaven changed the title perf(shim): Update kiennq-shim to v3.0 perf(shim): Update kiennq-shim to v3.1 Mar 22, 2024
@niheaven
Copy link
Member Author

Updated to v3.1

@chawyehsu
Copy link
Member

Thanks for the quick response.

@niheaven niheaven merged commit 5153d73 into develop Mar 22, 2024
2 checks passed
@niheaven niheaven deleted the perf-kiennq-shim branch March 22, 2024 11:06
brian6932 added a commit to brian6932/Scoop that referenced this pull request Mar 24, 2024
@kiennq
Copy link
Contributor

kiennq commented Mar 25, 2024

@niheaven @brian6932 I have discovered a recent issue with v3.1 kiennq shim, can you please update to version v3.1.1?
The issue prevents launching any new shim that's created from v3.1 kiennq shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants