more tests

Scottmitch · Oct 4, 2023 · ebbb40a · ebbb40a
1 parent b2dd1fc
commit ebbb40a
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/...current-api/src/test/java/io/servicetalk/concurrent/api/OnCompleteErrorPublisherTest.java b/...current-api/src/test/java/io/servicetalk/concurrent/api/OnCompleteErrorPublisherTest.java
@@ -18,6 +18,8 @@
 import io.servicetalk.concurrent.test.internal.TestPublisherSubscriber;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import static io.servicetalk.concurrent.api.Publisher.from;
 import static io.servicetalk.concurrent.api.SourceAdapters.toSource;
@@ -38,9 +40,23 @@ void errorPassThrough() {
     }
 
     @Test
-    void completeToError() {
+    void nullCompletes() {
+        toSource(Publisher.<Integer>empty()
+                .onCompleteError(() -> null)
+        ).subscribe(subscriber);
+        subscriber.awaitOnComplete();
+    }
+
+    @ParameterizedTest(name = "{displayName} [{index}] shouldThrow={0}")
+    @ValueSource(booleans = {false, true})
+    void completeToError(boolean shouldThrow) {
         toSource(from(1)
-                .onCompleteError(() -> DELIBERATE_EXCEPTION)
+                .onCompleteError(() -> {
+                    if (shouldThrow) {
+                        throw DELIBERATE_EXCEPTION;
+                    }
+                    return DELIBERATE_EXCEPTION;
+                })
         ).subscribe(subscriber);
         subscriber.awaitSubscription().request(1);
         assertThat(subscriber.takeOnNext(), equalTo(1));