Auto Generated ActiveEnum String Values And Model Column Names #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyt2y3 @billy1624 Can I ask for your opinions for these:
|
anshap1719
force-pushed
the
auto-generated-active-enum-strings
branch
from
208c70c
to
f23ebac
Compare
|
Hi @tyt2y3 @billy1624, sorry to ping you about this! Did you get a chance to look at it yet? |
billy1624
reviewed
Apr 25, 2024
billy1624
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Hey @anshap1719, thanks for the PR! I think this is a good alternative to the existing renaming of entity columns and active enum variants!
anshap1719
force-pushed
the
auto-generated-active-enum-strings
branch
from
f23ebac
to
35bca74
Compare
…ants Based On Renaming Rules SeaQL#2160
… Tests For DeriveActiveEnum rename rules SeaQL#2160
anshap1719
force-pushed
the
auto-generated-active-enum-strings
branch
from
a349af0
to
c1cd1ac
Compare
|
@billy1624 This is ready for your review in my opinion. |
|
Thanks @billy1624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
string_valueFor ActiveEnum Based On Renaming Rules On Variants #2160, Atomically pick a string_value value if not provided. #2125New Features
column_name_caseattribute inDeriveEntityModelfor automatically generating column names for all fields based on case style provided.column_name_caseattribute in fields within a model that derivesDeriveEntityModelfor automatically generating column name based on case style provided.rename_allattribute inDeriveActiveEnumfor automatically generating string values for all variants of the enum based on case style provided.renameattribute for variants of anActiveEnumthat derivesDeriveActiveEnumfor automatically generating string value for it based on case style provided.Dependents