#661: Add flag to sea-orm-cli to generate code for time crate

[nahuakang]

PR Info

• Closes Add flag to sea-orm-cli to generate code for time crate #661

Adds

• Adds a new flag date-time-crate to sea-orm-cli, which enables users to generate entities with either chrono or time crates

Fixes

• N/A

Breaking Changes

• N/A

Changes

• Introduces EntityWriterContext that handles expanded_format, with_serde and date_time_crate per discussion here:

pub struct EntityWriterContext {
    pub(crate) expanded_format: bool,
    pub(crate) with_serde: WithSerde,
    pub(crate) date_time_crate: DateTimeCrate,
}

[ikrivosheev]

I think we can merge this after: #706.

[nahuakang]

@ikrivosheev Sounds good. I'll make the cli adjustment to clap derive after #706 merged.

[ikrivosheev]

@nahuakang, hello, can you resolve conflicts?

[nahuakang]

Sure, I'll get this done this week 👍

[billy1624]

We have upgraded clap to 3.2. We could rebase current PR onto latest master :)

• Bump clap version to 3.2 #706

[nahuakang]

@billy1624 @ikrivosheev Just rebased :) I like the new declare style for commands!

[ikrivosheev]

@nahuakang thank you for PR! One comment)

[ikrivosheev]

LGTM!

[nahuakang]

@ikrivosheev @billy1624 Tests are failing due to the fact that sea-orm-codegen is required for the arg enum wrapper we implemented yesterday. The failure, I suspect, is due to the fact that sea-orm-codegen isn't included as a dependency for some of the features? Do you have a tip on how to proceed here?

[billy1624]

@ikrivosheev @billy1624 Tests are failing due to the fact that sea-orm-codegen is required for the arg enum wrapper we implemented yesterday. The failure, I suspect, is due to the fact that sea-orm-codegen isn't included as a dependency for some of the features? Do you have a tip on how to proceed here?

Hey @nahuakang, we could implement the conversion inside commands module, where we have codegen feature enabled, i.e. we have sea-orm-codegen in scope. Feel free to cherry-pick the useful bits

• https://github.com/nahuakang/sea-orm/compare/661_time_crate_flag...billy1624:sea-orm:pr/724

[nahuakang]

@billy1624 @ikrivosheev The most recent commit will throw an error as well for the examples tests. Do you know how I should import the enum into cli.rs?

[tyt2y3]

Thank you so much for the contribution. With this addition, we should begin a transition from chrono to time as the default recommended library soon, although we might postpone that to 0.10.0 because I'd imagine quite an amount of work to change everything across the board.