Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeDB] ProgressReport Media schema #3111

Merged
merged 5 commits into from Mar 12, 2024
Merged

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Mar 8, 2024

No description provided.

@CarsonF
Copy link
Member Author

CarsonF commented Mar 9, 2024

Fix for generation here: edgedb/edgedb-js#900

Copy link
Member

@andrewmurraydavid andrewmurraydavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work, @CarsonF !

Yes, it's bugged here. But it also hasn't proven useful.
The other two generators give us what we need.

Makes sense as GQL's interface generator isn't useful either,
but rather we generate bespoke types for each operation.
@CarsonF CarsonF merged commit 9ed3bac into develop Mar 12, 2024
15 checks passed
@CarsonF CarsonF deleted the edgedb/progress-report-media branch March 12, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants