Add save/load functionality #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
Added Save and Load functions
Added Save and Load functions
I copied the reset and created load/save.
Revert "Added Save and Load functions"
Sorry - I was travelling while you guys were talking about this. I removed the local storage requirement and gave credit to the original author. I tested and it works on Chrome and Firefox. Both browsers use the same codepath. I also tested Safari and note that the console doesn't work (the top panels don't show up. I doubt that's related to my change, but thought I would mention it.)
|
Will give it a try tomorrow |
|
Justed tested the current version. Here is a Screenshot of how the changes look like ATM:
Feature wise:
UI wise:
general discussion: maybe it would make sense to export/import the file into Gists instead of local files? Summary: the feature itself is nice, but the UI needs some polish before this can be merged. Thanks for your work so far. |
Seldaek
changed the title
|
@lowrykun any updates on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the delay...