Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow leader election controls for manager #4211

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Allow leader election controls for manager #4211

merged 2 commits into from
Jul 14, 2022

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Allows leadership election controls for manager. This will allow more control for devops in clusters that may have noisy/slow leadership election scenarios.

Which issue(s) this PR fixes:

Fixes #4147

Special notes for your reviewer:

@axsaucedo
Copy link
Contributor

Looks good and basic tests locally seem to validate - running inteagrtion tests but we should be good to merge
/test integration

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration df11e69 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Only test fail is confirmed flaky - moving ahead with merge
/approve

@axsaucedo axsaucedo merged commit a228ce3 into SeldonIO:master Jul 14, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon core operator is restarting due to failed renewal of lease
3 participants