Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb][bidi] network module events #12228

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

TamsilAmani
Copy link
Contributor

@TamsilAmani TamsilAmani commented Jun 19, 2023

Description

Add network module events and types

Motivation and Context

Implement network module events and types as described in https://w3c.github.io/webdriver-bidi/#module-network

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani TamsilAmani force-pushed the rb-bidi-network-module branch 2 times, most recently from 08f6234 to b63c1dc Compare June 20, 2023 13:07
@TamsilAmani TamsilAmani marked this pull request as ready for review June 20, 2023 13:07
@TamsilAmani TamsilAmani requested a review from p0deje June 20, 2023 13:08
@TamsilAmani
Copy link
Contributor Author

TamsilAmani commented Jun 20, 2023

@p0deje @titusfortner
This time I haven't wrapped the response from the browser into any object. Giving the user response as it is. Do you agree with this approach?

In another module (Script) I have wrapped the response into custom-defined classes which I need to change as per your suggestions.
#12082

Copy link
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great. In regards to wrapping request/response, I think we can iterate later and generalize rb/lib/selenium/webdriver/devtools/request.rb and rb/lib/selenium/webdriver/devtools/response.rb later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants