Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py] Remove unsupported safari parameters from Options #12454

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[py] Remove unsupported safari parameters from Options #12454

merged 1 commit into from
Aug 1, 2023

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jul 31, 2023 •
edited

Description

This is all that is supported in Safari: https://developer.apple.com/documentation/webkit/about_webdriver_for_safari

  • Remove logging level
  • Remove arguments
  • Remove binary_location
  • There is no safari.options
  • Superclass has correct behaviors for constructor, to_capabilities

Motivation and Context

  • All Safari support for Selenium 4.11.0 is broken when using Selenium Manager
  • Safari actually errors when you try to pass these things to the driver so no need to deprecate, they *can't be getting used
  • Selenium Manager incorrectly assumed the binary_location method was not implemented

Note: it also needed this - 2ee529e

@titusfortner titusfortner requested review from AutomatedTester and symonk and removed request for AutomatedTester and symonk July 31, 2023 21:33
@titusfortner titusfortner merged commit 4beab57 into trunk Aug 1, 2023
24 checks passed
@titusfortner titusfortner deleted the py_safari branch August 1, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@titusfortner