Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Less v4 #76

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ninjascribble
Copy link

less v4 introduces some breaking changes which this PR addresses.

@@ -36,7 +36,7 @@
@headerFontWeight: @bold;
@headerDisplay: block;
@headerDistance: 0rem;
@headerMargin: -@headerLineHeightOffset 0em @headerDistance 0em;
@headerMargin: calc(-1 * @headerLineHeightOffset) 0em @headerDistance 0em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this calc() here on purpose?

@@ -51,7 +51,7 @@

/* Result Content */
@resultTitleFont: @headerFont;
@resultTitleMargin: -@headerLineHeightOffset 0em 0em;
@resultTitleMargin: calc(-1 * @headerLineHeightOffset) 0em 0em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another calc() where I'm not sure if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants