Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix(Transition): hiding automatically when setState of parent called on mount #3685

Closed
wants to merge 2 commits into from

Conversation

DmitryRomaniuk
Copy link

Fixes #3641

@welcome
Copy link

welcome bot commented Jul 1, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@DmitryRomaniuk
Copy link
Author

I fixed, review plz and now I'm trying to write appropriate test

@layershifter
Copy link
Member

This issue was fixed in semantic-ui-react@1.0.0 by #3982. Closing for housekeeping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition: hiding automatically when setState of parent called on mount
2 participants