Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): add 'inputMode' attribute to input #3916

Merged
merged 2 commits into from Jun 23, 2020

Conversation

RoyalHunt
Copy link
Contributor

The inputmode attribute provides a hint to browsers for devices with onscreen keyboards to help them decide which keyboard to display.

The inputmode global attribute provides a hint to browsers for devices with onscreen keyboards to help them decide which keyboard to display.
@welcome
Copy link

welcome bot commented Mar 25, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

Codecov Report

Merging #3916 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3916   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3150     3150           
=======================================
  Hits         3145     3145           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71b0a1...77da547. Read the comment docs.

@layershifter
Copy link
Member

@RoyalHunt good catch 👍

@layershifter layershifter changed the title Add 'inputMode' attribute to input. fix(Input): add 'inputMode' attribute to input Jun 23, 2020
@layershifter layershifter merged commit 9513785 into Semantic-Org:master Jun 23, 2020
@welcome
Copy link

welcome bot commented Jun 23, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants