fix(TransitionablePortal): fixed deprecated lifecycle method #2732

[shachar731945]

• removed deprecated componentWillReceiveProps lifecycle

• changed it to componentDidUpdate

• changed test description to componentDidUpdate

it is worth mentioning that it is not advised to use getDerivedStateFromProps in this case due to the different time this hook is getting called in contrast to componentDidUpdate which also does not require change from any of the test

[welcome]

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

• Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
• Run yarn test locally to catch errors. This ensures all components still behave as they should.
• Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
• Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[shachar731945]

my circle ci checks are not working because i have setState in componentDidUpdate. I would like to know if this check is missused in the circleci checks or is there an actual reason for it. thanks from ahead.

[NicholasG04]

See https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-update-set-state.md maybe as to why?

[layershifter]

Oops, folks 😿 I missed that this PR exists...

I did an update in #3966 and you can check it if you're interested. In general when there is UNSAFE_componentWillReceiveProps that performs setState() it should be replaced with getDerivedStateFromProps() as otherwise componentDidUpdate() will cause double render.