Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Sticky): remove usage of deprecated lifecycle methods #3974

Merged
merged 1 commit into from Jun 29, 2020

Conversation

layershifter
Copy link
Member

Related to #3919.

Removes the usage of UNSAFE_componentWillReceiveProps for Sticky.

@codecov-commenter
Copy link

Codecov Report

Merging #3974 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         180      180              
  Lines        3171     3169       -2     
==========================================
- Hits         3166     3164       -2     
  Misses          5        5              
Impacted Files Coverage Δ
src/modules/Sticky/Sticky.js 99.07% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adb4bf...42982b3. Read the comment docs.

@layershifter layershifter merged commit 20d851d into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/sticky-no-dep branch June 29, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants