Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove knobs usage #3988

Merged
merged 4 commits into from Jul 17, 2020
Merged

docs: remove knobs usage #3988

merged 4 commits into from Jul 17, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 17, 2020

Fixes #3929.

Our examples are designed to be easy copy-pastable, but knobs broke this experience (see #3929). This PR removes their usage in examples.
Also adds config for Vercel deployments.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #3988 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3988   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3157     3157           
=======================================
  Hits         3152     3152           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513f70e...0c8ee0b. Read the comment docs.

@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/semantic-ui/semantic-ui-react/a2fncrm9k
✅ Preview: https://semantic-ui-react-git-docs-remove-knobs.semantic-ui.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement sidebar in react ^16.13.1
2 participants