chore: support React 17 #4031
chore: support React 17 #4031
Conversation
size-limit report
|
|
Note: For now, you can use 3rd party adapter I built based on |
Codecov Report
@@ Coverage Diff @@
## master #4031 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 186 186
Lines 3255 3255
=======================================
Hits 3250 3250
Misses 5 5 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4031 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3241 3241
=======================================
Hits 3233 3233
Misses 8 8 Continue to review full report at Codecov.
|
layershifter
force-pushed
the
chore/use-react-17
branch
from
55c24df
to
8b6d934
Compare
…React into chore/use-react-17
…React into chore/use-react-17
| @@ -40,11 +40,9 @@ const Document = ({ Body, children, Head, Html, siteData: { dev, versions } }) = | |||
| }.js`} | |||
| /> | |||
| <script | |||
| src={ | |||
| dev | |||
| ? ` https://cdn.jsdelivr.net/npm/@hot-loader/react-dom@${versions.react}/umd/react-dom.development.js` | |||
There was a problem hiding this comment.
There is no @hot-loader/react-dom for 17.0.1. It also creates weird issues with HMR...
Fixes #4028.
On public side
This PR updates
peerDependenciesto avoid warnings related to React versions mismatch.On our side
Updates React & dev dependencies to run our doc site and tests with React 17, with this we can ensure that nothing is broken. Currently shipped with unofficial adapter for Enzyme and there is no support for React 17 (enzymejs/enzyme#2429).