fix(Table): fix react key error on sibling cells with same string content #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #4198 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3241 3244 +3
=======================================
+ Hits 3233 3236 +3
Misses 8 8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4034, also include a test and documentation for
tableDataattribute usage in Table component.Please have a look especially at line 68 of
src/collections/Table/TableRow.js.The newly created react key of "string containing" cells will have the following format (screenshot taken from docs):
In my opinion, this should be a good way to create "unique" keys for the cells because the cell index is also used for key creation.
But I don't know if creating the React Key attribute this way may have mentionable performance impact in huge lists. At least it should have a little but in sake of errorless rendering.