chore(Visibility): remove component #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next-v3 #4257 +/- ##
===========================================
+ Coverage 99.49% 99.55% +0.05%
===========================================
Files 187 181 -6
Lines 3561 3350 -211
===========================================
- Hits 3543 3335 -208
+ Misses 18 15 -3
Continue to review full report at Codecov.
|
layershifter
added
PR: Breaking Change 💥
and removed
PR: Internal 🏠
wip
layershifter
force-pushed
the
chore/remove-visibility
branch
from
edb7787
to
8799180
Compare
layershifter
added a commit
that referenced
this pull request
Feb 1, 2022
* chore(Visibility): remove component * remove behaviors section
layershifter
added a commit
that referenced
this pull request
Feb 18, 2022
* chore(Visibility): remove component * remove behaviors section
layershifter
added a commit
that referenced
this pull request
Apr 22, 2022
* chore(Visibility): remove component * remove behaviors section
layershifter
added a commit
that referenced
this pull request
Jun 21, 2022
* chore(Visibility): remove component * remove behaviors section
layershifter
added a commit
that referenced
this pull request
Dec 12, 2022
* chore(Visibility): remove component * remove behaviors section
layershifter
added a commit
that referenced
this pull request
Dec 13, 2022
* chore(Visibility): remove component * remove behaviors section
levithomason
pushed a commit
that referenced
this pull request
Feb 28, 2023
* chore: remove .state() assertions in tests (#4232) * Ember: remove .state() usage in Enzyme * AccordionAccordion: remove .state() usage in Enzyme * Checkbox: remove .state() usage in Enzyme * TransitionablePortal: remove .state() usage in Enzyme * Transition: remove .state() usage in Enzyme * Dropdown: remove .state() usage in Enzyme * chore(Image): use React.forwardRef() (#4234) * chore(Placeholder): use React.forwardRef() (#4236) * chore(Header): use React.forwardRef() (#4237) * chore(Segment): use React.forwardRef() (#4238) * chore(Table): use React.forwardRef() (#4239) * chore(Table): use React.forwardRef() * fix naming * chore(Step): use React.forwardRef() (#4240) * chore: disable ESLint rule for function names (#4241) * chore(Comment): use React.forwardRef() (#4242) * chore(Comment): use React.forwardRef() * fix displayName * fix tests * chore(Card): use React.forwardRef() (#4243) * chore(Feed): use React.forwardRef() (#4244) * chore(Statistic): use React.forwardRef() (#4245) * chore(Item): use React.forwardRef() (#4247) * chore(Container|Divider|Loader|Rail): use React.forwardRef() (#4248) * chore(Accordion): use React.forwardRef() (#4249) * chore(Advertisement|Breadcrumb): use React.forwardRef() (#4250) * chore(Message): use React.forwardRef() (#4251) * chore(Label|List): use React.forwardRef() (#4252) * chore(Menu): use React.forwardRef() (#4254) * chore(Pagination): use React.forwardRef() (#4255) * chore(Button): use React.forwardRef() (#4256) * chore(Modal|Portal|Popup): use React.forwardRef() (#4253) * chore(Modal|Portal): use React.forwardRef() * remove redundant statics * migrate Popup * chore(Rating|Reveal): use React.forwardRef() (#4258) * chore(Dimmer|Grid|Sidebar): use React.forwardRef() (#4260) * chore(Modal*|Popup*): use React.forwardRef() (#4261) * chore(Confirm|Checkbox|Embed|Radio|TextArea): use React.forwardRef() (#4262) * chore(Flag|Icon|ImageGroup): use React.forwardRef() (#4264) * chore(Tab): use React.forwardRef() (#4265) * chore(TransitionGroup): use React.forwardRef() (#4266) * chore(Input): use React.forwardRef() (#4267) * chore(Sticky): use React.forwardRef() (#4263) * chore(TransitionablePortal): convert to be functional component (#4269) * chore(Search*): use React.forwardRef() (#4270) * chore(Dropdown*): use React.forwardRef() (#4273) * chore(Dropdown*): use React.forwardRef() * fix examples-test * chore(Visibility): remove component (#4257) * chore(Visibility): remove component * remove behaviors section * chore(Ref): remove component (#4286) * chore(Ref): remove component * fix tests * chore(Search): use React.forwardRef() (#4330) * chore(Search): use React.forwardRef() * add test for ref forwarding * fix tests, add comments * chore: refactor Modal tests (#4339) * chore: remove unused test utils (#4340) * chore: refactor tests for classnames to use mount() (#4341) * chore: refactor tests for shorthands to use mount() (#4342) * chore: refactor tests for shorthands to use mount() * add comment * fix tests with unmount * fix(Dropdown): use ref forwarding (#4338) * Add forward ref to Form (#4364) * Convert form to function component * Add ref forwarding to Form component * Update test/specs/collections/Form/Form-test.js Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Add ref to components (#4373) * Add ref to FormButton * Add ref to FormCheckbox * Add forwardRef to FormGroup * Remove accidental `only` calls * chore(FormField): use React.forwardRef() (#4359) * Add ref to form field component * Move ref to controlProps * Add more forwardsRef tests * Remove unnecessary describe wrapper * update tests Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * chore(FormTextArea): use React.forwardRef() (#4405) * chore(FormRadio): use React.forwardRef() (#4406) * chore(FormInput): use React.forwardRef() (#4407) * chore(Select,FormSelect,FormDropdown): use React.forwardRef() (#4408) * chore(Select): use React.forwardRef() * chore(FormSelect): use React.forwardRef() * chore(FormDropdown): use React.forwardRef() * fix tests, fix Dropdown component Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> --------- Co-authored-by: Brandon Olivier <brandon@brandonolivier.com> Co-authored-by: Felix Mosheev <9304194+felixmosh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
This PR removes
Visibilitycomponent.The main reason is performance that is far away from native APIs, even in our docs we use Intersection Observer API (#3985).
Migration
We suggest to use Intersection Observer API directly or via React wrappers, for example: react-intersection-observer.
As it's not a straightforward replacement that may cause issues with adoption we moved out
Visibilitycomponent to a separate package (@semantic-ui-react/component-visibility). This means that you can use it already with v2 or upcoming v3:⚠ Notice
@semantic-ui-react/component-visibilityis considered as a deprecated package, we don't plan maintain it, so please consider migration anyway. It also will not receive fixes related to usage of deprecated APIs from React.