Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): update types to support ref #4447

Merged
merged 1 commit into from Dec 10, 2023

Conversation

layershifter
Copy link
Member

Fixes #4432.

  • Adds ForwardRefComponent type
  • Adds conformance tests to ensure that a type for a component exists and it had proper type
  • Updates all components' types

Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 54.05 KB (0%)
bundle-size/dist/Icon.size.js 27.35 KB (0%)
bundle-size/dist/Image.size.js 49.61 KB (0%)
bundle-size/dist/Modal.size.js 62.61 KB (0%)
bundle-size/dist/Portal.size.js 37.18 KB (0%)

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ef16a) 99.51% compared to head (444f60f) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4447   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         186      186           
  Lines        3512     3512           
=======================================
  Hits         3495     3495           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@layershifter layershifter merged commit e243fa4 into master Dec 10, 2023
10 checks passed
@layershifter layershifter deleted the chore/fix-typings-to-support-ref branch December 10, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve typings [v3]
1 participant