Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add "use client" directive in components where it's needed #4452

Merged
merged 1 commit into from Dec 30, 2023

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Dec 30, 2023

This PR fixes #4433.

⚠️ Heads up

Next.js does not support List.Item syntax i.e. ListItem works List.Item does not 💥 There is an issue related to the problem (vercel/next.js#44389), however with current implementation I don't believe that it's solvable on their side. I will create a follow-up PR to update examples to not reference that syntax.

Copy link

github-actions bot commented Dec 30, 2023

size-limit report

Path Size
bundle-size/dist/Button.size.js 53.86 KB (-0.3% 🔽)
bundle-size/dist/Icon.size.js 27.34 KB (-0.06% 🔽)
bundle-size/dist/Image.size.js 49.45 KB (-0.28% 🔽)
bundle-size/dist/Modal.size.js 62.32 KB (-0.36% 🔽)
bundle-size/dist/Portal.size.js 37.12 KB (-0.21% 🔽)

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8700e57) 99.50% compared to head (7921437) 99.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files         186      186              
  Lines        3466     3465       -1     
==========================================
- Hits         3449     3448       -1     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@layershifter layershifter merged commit 3b54506 into master Dec 30, 2023
9 of 10 checks passed
@layershifter layershifter deleted the chore/use-client-for-next branch December 30, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with next.js 13 server components
1 participant