Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "linkedin in" icon name to enumeration to fix console error #4471

Merged
merged 1 commit into from Mar 11, 2024

Conversation

mwaddell
Copy link

fixes #4470 by adding the "linkedin in" name to the existing enumerations

Copy link

welcome bot commented Mar 11, 2024

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 5:29pm

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2.x@a32499d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #4471   +/-   ##
=======================================
  Coverage        ?   99.75%           
=======================================
  Files           ?      180           
  Lines           ?     3249           
  Branches        ?        0           
=======================================
  Hits            ?     3241           
  Misses          ?        8           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwaddell mwaddell changed the title fix: add "linkedin in" icon name to enumeration to fix typescript error fix: add "linkedin in" icon name to enumeration to fix console error Mar 11, 2024
@layershifter layershifter merged commit 6d84dd1 into Semantic-Org:v2.x Mar 11, 2024
9 of 10 checks passed
Copy link

welcome bot commented Mar 11, 2024

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

Oops, I haven't mentioned that it targets v2 branch. @mwaddell I will cherry pick commit to master branch.

@mwaddell
Copy link
Author

mwaddell commented Mar 11, 2024

Oops, I haven't mentioned that it targets v2 branch. @mwaddell I will cherry pick commit to master branch.

Thank you @layershifter - I identified the issue in v2.1.5 which is why I targeted that branch - we haven't migrated any of our code to target 3.x yet since it's still in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants