Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #693

Closed
wants to merge 2 commits into from
Closed

Upgrade dependencies #693

wants to merge 2 commits into from

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Jun 5, 2020

typescript:
microsoft/TypeScript#38535
I got the same error, I have fixed it
XY is specified more than once, so this usage will be overwritten.
This spread always overwrites this property.

<Table
  rowHeight={tableProps.rowHeight}  //removed
  headerHeight={tableProps.headerHeight || 42}  //removed
  {...tableProps} />

It is valid: table has the rowHeight and headerHeight prop twice, cause in tableProps these are mandatory.


New tslib version is not compatible with react-quill we should check it after this released: zenoamaro/react-quill#549 (now it has only beta version)


webpack:
the plugin now accepts an object, you should change new CopyPlugin(patterns, options) to new CopyPlugin({ patterns, options })


Eslint breaking changes:
@typescript-eslint/explicit-module-boundary-types: Missing return type on function. --> now it throw warning ( I have disabled it till we fix these problems)
@typescript-eslint/prefer-as-const: Expected a const instead of a literal type assertion ( I have disabled it till we fix these problems)
@typescript-eslint/ban-ts-comment: Don't use object as a type. The object type is currently hard to use etc. ( I have disabled it till we fix these problems)
@typescript-eslint/no-extra-non-null-assertion ( I have disabled it till we fix these problems)
@typescript-eslint/no-extra-semi ( I have disabled it till we fix these problems)
@typescript-eslint/no-non-null-asserted-optional-chain" ( I have disabled it till we fix these problems)
@typescript-eslint/ban-types ( I have disabled it till we fix these problems)

"@typescript-eslint/camelcase": "error", is removed so I delete these comments from code: // eslint-disable-next-line @typescript-eslint/camelcase


New version of Monaco-editor is still not working with our code


Action plan:

@enikonemeth enikonemeth added this to the Sprint 211 milestone Jun 5, 2020
@enikonemeth enikonemeth requested review from herflis and taki9 June 5, 2020 15:57
@enikonemeth enikonemeth self-assigned this Jun 5, 2020
@sensenet
Copy link

sensenet bot commented Jun 5, 2020

Site name Url Last deploy
sn-app-dev https://5ede6419066a6f696b0fae8b--sn-app-dev.netlify.app Mon Jun 08 2020 - 16:15:22 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://5ede641d43ebac6c0339af08--sn-react-component-docs-dev.netlify.app Mon Jun 08 2020 - 16:15:25 GMT+0000 (Coordinated Universal Time)

@enikonemeth enikonemeth deleted the feature/dep_upgrade branch June 10, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant