Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel/Storage: Remove ATA IDE support #24160

Merged
merged 1 commit into from May 14, 2024

Conversation

supercomputer7
Copy link
Member

@supercomputer7 supercomputer7 commented Apr 29, 2024

Nobody uses this functionality. I used this code on my old 2007 ICH7 test machine about a year ago, but bare metal is a small aspect of the project, so it's safe to assume that nobody really tests this piece of code.
Therefore, let's drop this for good and focus on more modern hardware.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Apr 29, 2024
@supercomputer7 supercomputer7 force-pushed the remove-ata-ide-support branch 3 times, most recently from 6702156 to ed16498 Compare April 29, 2024 19:09
@supercomputer7
Copy link
Member Author

I rebased this and force-pushed to see if the CI flakiness is resolved.

Nobody uses this functionality. I used this code on my old 2007 ICH7
test machine about a year ago, but bare metal is a small aspect of the
project, so it's safe to assume that nobody really tests this piece of
code.
Therefore, let's drop this for good and focus on more modern hardware.
Copy link
Member

@ADKaster ADKaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, less code is less code after all

@ADKaster ADKaster merged commit 2cb86c1 into SerenityOS:master May 14, 2024
12 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants