LibWeb: Improve resolution of ResolvedCSSStyleDeclaration properties
#24248
+111
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
tcl3
commented
May 6, 2024
| @@ -102,7 +102,7 @@ list-style-position: outside | |||
| list-style-type: disc | |||
| margin-block-end: 8px | |||
| margin-block-start: 8px | |||
| margin-bottom: 8px | |||
| margin-bottom: 16px | |||
There was a problem hiding this comment.
This appears to be incorrect, but I'm not sure whether this is due to something I've done, or some issue with margin calculation elsewhere.
The resolved value is now correctly calculated for all margin, padding and width properties of a `ResolvedCSSStyleDeclaration`. This means the correct values are returned when these properties are accessed from a `getComputedStyle()` call.
tcl3
force-pushed
the
libweb_getcomputedstyle_relative_values
branch
from
a3572f0
to
5a06051
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolved value is now correctly calculated for all margin, padding and width properties of a
ResolvedCSSStyleDeclaration.This means the correct values are returned when these properties are accessed from a
getComputedStyle()call.This allows the following WPT tests to pass: