Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/SVG: Implement SVGAnimated{Boolean,Enumerated,Integer} types #24268

Closed
wants to merge 4 commits into from

Conversation

jamierocks
Copy link
Contributor

I was reading into the Filter effects specification, and realised these were missing.

Work towards GH-24168 and GH-23943.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 8, 2024
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The spec actually specifies what steps to take when setting or getting the base/animated values, so it'd be good to implement those here, or at least put some FIXMEs in.

@jamierocks
Copy link
Contributor Author

Looking into how these should be implemented properly with all the reflected values, etc - it might be best if these are implemented when <filter>/whatever uses them is done.

@jamierocks jamierocks closed this May 22, 2024
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants