Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AK: Add stack size fixup for musl libc #24287

Merged
merged 1 commit into from May 14, 2024

Conversation

ptrcnull
Copy link
Contributor

Fixes #16681

@ptrcnull
Copy link
Contributor Author

locally, on musl 1.2.5 ( Alpine Linux edge ) only one test fails:

 91/204 Test  #91: TestPrint ............................***Exception: Illegal  0.00 sec
Running 5 cases out of 5.
Running test 'swprint_no_format'.
Completed test 'swprint_no_format' in 0ms
Running test 'swprint_single_wchar_argument'.
Completed test 'swprint_single_wchar_argument' in 0ms
Running test 'swprint_single_char_argument'.
Completed test 'swprint_single_char_argument' in 0ms
Running test 'swprint_single_narrow_char_argument'.
VERIFICATION FAILED: wcscmp(buffer, L"Well, hello friends!") == 0 at /home/patrycja/Downloads/serenity/Tests/AK/TestPrint.cpp:45

@ptrcnull ptrcnull force-pushed the musl-stackinfo branch 2 times, most recently from 2752f7c to 2d3d92a Compare May 12, 2024 01:58
@ptrcnull ptrcnull marked this pull request as ready for review May 12, 2024 17:25
@ptrcnull ptrcnull changed the title WIP: AK: Add stack size fixup for musl libc AK: Add stack size fixup for musl libc May 12, 2024
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 12, 2024
@ADKaster ADKaster merged commit 13e44ab into SerenityOS:master May 14, 2024
14 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackInfo issues on Alpine (musl-based)
2 participants