AK+Everywhere: De-duplicate stack unwinding functions #24292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of duplicating stack unwinding code everywhere, introduce a new AK helper to unwind the stack in a generic way.
github-actions
bot
added
the
👀 pr-needs-review
spholz
force-pushed
the
ak-stack-unwinding
branch
from
efc0c44
to
a46b235
Compare
spholz
force-pushed
the
ak-stack-unwinding
branch
from
a46b235
to
ffb1f05
Compare
ADKaster
approved these changes
May 14, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently implement stack unwinding in a lot of places.
Instead of making all of them RISC-V-aware and therefore creating even more duplicate code, this PR adds a new generic AK helper for stack unwinding.
I hope I found all stack unwinding implementations.