Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Add more emoji (Emoji 16 edition) #24297

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

Xexxa
Copy link
Collaborator

@Xexxa Xexxa commented May 12, 2024

These are the current Emoji 16 alpha emoji.

x67-screenshot

馃 - U+1FAE9 FACE WITH BAGS UNDER EYES
馃珶 - U+1FADF SPLATTER
馃獕 - U+1FA89 HARP
馃珕 - U+1FAC6 FINGERPRINT
馃珳 - U+1FADC ROOT VEGETABLE
馃 - U+1FABE LEAFLESS TREE
馃獜 - U+1FA8F SHOVEL
馃嚚馃嚩 - U+1F1E8_U+1F1F6 CQ SARK

https://www.unicode.org/review/pri498/pri498-emoji-recently-added-v16-0%CE%B1.pdf

@github-actions github-actions bot added the 馃憖 pr-needs-review PR needs review from a maintainer or community member label May 12, 2024
@Xexxa
Copy link
Collaborator Author

Xexxa commented May 14, 2024

Is the issues :ciflakes:? 馃

@ADKaster
Copy link
Member

Is the issues :ciflakes:? 馃

I don't think we can add these emoji until we start downloading https://www.unicode.org/Public/emoji/16.0/emoji-test.txt

Currently we still only download the file for version 15.1, same as our UCD data.

@ADKaster ADKaster requested a review from trflynn89 May 14, 2024 01:20
@trflynn89
Copy link
Member

Putting these in emoji-serenity.txt is fine until Unicode 16 is released, but I think the issue is the last line::

U+1F1E8_U+1F1F6 CQ SARK

There should not be an underscore between the code points, there should just be a space:

U+1F1E8 U+1F1F6 CQ SARK

馃 - U+1FAE9 FACE WITH BAGS UNDER EYES
馃珶 - U+1FADF SPLATTER
馃獕 - U+1FA89 HARP
馃珕 - U+1FAC6 FINGERPRINT
馃珳 - U+1FADC ROOT VEGETABLE
馃 - U+1FABE LEAFLESS TREE
馃獜 - U+1FA8F SHOVEL
馃嚚馃嚩 - U+1F1E8_U+1F1F6 CQ SARK
@Xexxa
Copy link
Collaborator Author

Xexxa commented May 14, 2024

Putting these in emoji-serenity.txt is fine until Unicode 16 is released, but I think the issue is the last line::

U+1F1E8_U+1F1F6 CQ SARK

There should not be an underscore between the code points, there should just be a space:

U+1F1E8 U+1F1F6 CQ SARK

Thanks, you are totally right! TBH it's not usual I make two major mistakes for a simple emoji PR but the "Meta/emoji-file-list.txt" addition to my workflow has thrown me a bit out of balance... :^)

@trflynn89 trflynn89 merged commit bda9148 into SerenityOS:master May 14, 2024
11 checks passed
@github-actions github-actions bot removed the 馃憖 pr-needs-review PR needs review from a maintainer or community member label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants