Update Feedback #1091
Update Feedback #1091
Conversation
| @@ -102,9 +100,6 @@ const FeedbackModal = ({ service, resource, closeModal }) => { | |||
| <img src={icon('feedback-blue-header')} alt="feedback" /> | |||
| <span>Share your Feedback</span> | |||
| </div> | |||
| <div className={styles.feedbackSubheader}> | |||
There was a problem hiding this comment.
As of May of 2021 We didn't have a way of reaching back out so we had to remove sub-header message "Team will usually replies within a day"
| @@ -39,19 +40,22 @@ const FeedbackModal = ({ service, resource, closeModal }) => { | |||
| setReview(e.target.value); | |||
| }; | |||
|
|
|||
| const isDownVote = vote === DOWNVOTE; | |||
There was a problem hiding this comment.
Since this logic been used in multiple places decided to assign it to variable
|
|
||
| const tags = isDownVote | ||
| ? tagOptions.filter(({ selected }) => selected).map(({ tag }) => tag) | ||
| : []; |
There was a problem hiding this comment.
We wanna keep review and tags state consistent if user toggles between upvote and downvote but need to make sure we send empty tags before submit, since tags associated with downvote only. We need to make sure we don't add unwanted data. Here Feedback Modal for reference.
There was a problem hiding this comment.
Thanks for following up, this LGTM!
I think we're having a lot of issues with flaky CI runs, particularly the Cypress end-to-end tests. @jjfreund, @lexholden, @schroerbrian, we may need to prioritize getting CI to be more stable.
| placeholder={`Type your feedback here ${ | ||
| !isReviewRequired ? '(optional)' : '' | ||
| }`} | ||
| placeholder="Type your feedback here(optional)" |
There was a problem hiding this comment.
It'll look tidier and if you put a space between the word "here" and the parenthetical "(optional)":
| placeholder="Type your feedback here(optional)" | |
| placeholder="Type your feedback here (optional)" |
Closed this PR since it was outdated and opened new PR
Othertag and make it optional, product team want it to be a lightweight feedback experienceupvote(below added more info on this)