remove react-ga; configure integrations to work with exygy accounts #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the GA integration - which doesn't need to exist after Universal Analytics was deprecated. The GA4 integration still exists.
It also updates some of the public keys to integrations so our app won't be feeding into ShelterTech's sentry, ga4, etc. It also makes a GA4 integration optional. Essentially, this is getting the front end into a deployable state for an environment distinct from Shelter Techs.
Tasks
Notes
This PR raises concerns around how our changes impact the likelihood that ShelterTech's ask darcel repo will be synced one day. Curious if there are any thoughts. That's why I commented the react-ga code instead of deleting it, but that's not really a scaleable solution imo, at least for every change we make. I'd like to keep thinking about it for a bit and see what updates we end up making before coming up with a strategy.
I'll add the env vars to a 1password note and grant access to exygy folks as admins after pr approval.